Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the variable const #26509

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Made the variable const #26509

merged 4 commits into from
Apr 5, 2019

Conversation

amitsrivastava78
Copy link
Contributor

Variables which are not modified are made const

Made the variable const
4fbd19d 
Variables which are not modified are made const
Amit Srivastava added 2 commits March 9, 2019 15:20
Fixed few trival items in the file
f995d4e 
fixed some trival items
Fixed variables to be readonly
8747cc8 
Fixed trival issues
Made the const reference to the variable
1162bb1 
Created a const reference
@rthadur rthadur requested a review from haozha111 March 11, 2019 20:27
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 11, 2019
@rthadur rthadur self-assigned this Mar 11, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:S CL Change Size: Small labels Mar 11, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 25, 2019
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 26, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 26, 2019
@amitsrivastava78
Copy link
Contributor Author

@rthadur , i think the below error is not related to my changes, can you pls check and re trigger the build.

$TEST_TMPDIR defined: output root default is '/tmpfs/bazel_output' and max_idle_secs default is '15'.
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Traceback (most recent call last):
File "check_load_py_test.py", line 91, in
main()
File "check_load_py_test.py", line 85, in main
'\n'.join(files_missing_load)))
RuntimeError: The following files are missing load("//tensorflow:tensorflow.bzl", "py_test").
This load statement is needed because otherwise pip tests will try to use their dependencies, which are not visible to them.:
tensorflow/contrib/input_pipeline/BUILD
tensorflow/contrib/periodic_resample/BUILD

Regards
Amit

@haozha111
Copy link
Contributor

rthadur@, could you help take a look on why merging still blocked? Thanks!

@tensorflow-copybara tensorflow-copybara merged commit 1162bb1 into tensorflow:master Apr 5, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 5, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 5, 2019
@tensorflower-gardener
Merge pull request #26509 from amitsrivastava78:error_1
943a11f 
PiperOrigin-RevId: 242188523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haozha111 haozha111 haozha111 approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@amitsrivastava78 @haozha111 @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara @rthadur